Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement adapter Name and add Name constant #53

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Oct 3, 2023

Depends on go-rel/rel#346 and go-rel/sql#59

Add also MustOpen method similar to other adapters

sqlite3.go Show resolved Hide resolved
@lafriks lafriks changed the title Implement adapter DBType and add Name constant Implement adapter Name and add Name constant Oct 7, 2023
@lafriks lafriks marked this pull request as ready for review October 8, 2023 09:47
@lafriks lafriks requested a review from Fs02 October 8, 2023 11:06
Copy link
Member

@Fs02 Fs02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fs02 Fs02 merged commit 730f4a6 into go-rel:main Oct 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants